Repository navigation
Conversation
Owner
|
Thanks for the PR, but v3 is still too much in development that safety comments are worth it. I'm going to close this as I don't think it can be salvaged after the current rewrite I'm doing. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
lib/v3carries noSAFETYcomment on any of itsunsafeblocks, unlikelib, so each one now states its invariant,undocumented_unsafe_blocksis enabled to keep it that way, thefrom_utf8_uncheckedcalls assert their ASCII precondition withsafety_assert!aslibdoes, andcopy_from_slicedropsunsafebecause its shared-reference cast has no precondition.