Skip to content

IBX-11237: websiteId section added#3281

Merged
julitafalcondusza merged 8 commits into
5.0from
IBX-11237
Jul 15, 2026
Merged

IBX-11237: websiteId section added#3281
julitafalcondusza merged 8 commits into
5.0from
IBX-11237

Conversation

@julitafalcondusza

@julitafalcondusza julitafalcondusza commented Jul 7, 2026

Copy link
Copy Markdown
Contributor
Question Answer
JIRA Ticket (https://github.com/ibexa/connector-raptor/pull/13)
Versions 5.0

Checklist

  • Text renders correctly
  • Text has been checked with vale
  • Description metadata is up to date
  • Redirects cover removed/moved pages
  • Code samples are working
  • PHP code samples have been fixed with PHP CS fixer
  • Added link to this PR in relevant JIRA ticket or code PR

@github-actions

github-actions Bot commented Jul 7, 2026

Copy link
Copy Markdown

Preview of modified files

Preview of modified Markdown:

@julitafalcondusza julitafalcondusza marked this pull request as ready for review July 7, 2026 12:45
@julitafalcondusza julitafalcondusza requested review from Copilot and tbialcz and removed request for Copilot July 7, 2026 12:45
@github-actions

github-actions Bot commented Jul 7, 2026

Copy link
Copy Markdown

Summary

Status Count
🔍 Total 760088
🔗 Unique 15033
✅ Successful 7274
⏳ Timeouts 0
🔀 Redirected 0
👻 Excluded 752813
❓ Unknown 0
🚫 Errors 1
⛔ Unsupported 0

Errors per input

Errors in site/templating/twig_function_reference/recommendations_twig_functions/index.html

Full Github Actions output

@julitafalcondusza julitafalcondusza requested a review from a team July 8, 2026 05:59
@ibexa-workflow-automation-1 ibexa-workflow-automation-1 Bot requested review from adriendupuis, dabrt and mnocon and removed request for a team July 8, 2026 05:59
@julitafalcondusza julitafalcondusza requested review from a team and removed request for adriendupuis and dabrt July 8, 2026 05:59
@ibexa-workflow-automation-1 ibexa-workflow-automation-1 Bot requested review from adriendupuis and dabrt and removed request for a team July 8, 2026 07:03
Comment thread docs/templating/twig_function_reference/recommendations_twig_functions.md Outdated
Comment thread docs/templating/twig_function_reference/recommendations_twig_functions.md Outdated

@mnocon mnocon left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a confusing concept, and to make it clearer we need to provide better description of the use cases where the custom id should be provided.

The example with websiteId: 'ibexa_user_get_current().login' is not enough for two reasons:

  • it does not handle the anonymous user, for which the website id should not be set (at least that's how I understand this)
  • it's not clear whether it's recommended and better than the default behaviour - because by default, user id is sent as website id:

https://github.com/ibexa/connector-raptor/blob/1b622a028435145e513dc14b6cee8dd14bd076a4/src/lib/Tracking/ContextProvider/LoggedInUserWebsiteIdContextProvider.php#L20-L25 , based on user remote identifier:

https://github.com/ibexa/connector-raptor/blob/1b622a028435145e513dc14b6cee8dd14bd076a4/src/lib/Tracking/TrackingIdentifierProvider.php#L146-L159

The use cases I'm thinking of where providing a custom website id might be needed:

  • custom CRM scenario - if you store information about your customers in an external CRM system, you might use one of the identifiers stored there and send that instead of the default value
  • B2B scenario - send company identifier (the company the user belongs to) instead of an ID of a single user to track actions of the whole company, not a single user

Comment thread docs/templating/twig_function_reference/recommendations_twig_functions.md Outdated
Comment thread docs/templating/twig_function_reference/recommendations_twig_functions.md Outdated
Comment thread docs/templating/twig_function_reference/recommendations_twig_functions.md Outdated
Comment thread docs/templating/twig_function_reference/recommendations_twig_functions.md Outdated
@julitafalcondusza julitafalcondusza requested a review from mnocon July 13, 2026 09:47

@mnocon mnocon left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, just some small things to fix - formatting and applying Rector suggestion being the most important

Comment thread docs/templating/twig_function_reference/recommendations_twig_functions.md Outdated
Comment thread docs/templating/twig_function_reference/recommendations_twig_functions.md Outdated

@mnocon mnocon left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@julitafalcondusza julitafalcondusza merged commit 1887149 into 5.0 Jul 15, 2026
10 of 11 checks passed
@julitafalcondusza julitafalcondusza deleted the IBX-11237 branch July 15, 2026 11:33
julitafalcondusza added a commit that referenced this pull request Jul 15, 2026
* websiteId section added

* typos

* code language fixed

* fixes, content added

* fixes after rev

* fixes after doc rev

* fixes + rector

* rector fix
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants