Preserve SubscriptionText TSV column positions - #176
Merged
Conversation
Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01CbtimCQAVdGhaEFXsEGKPK
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
fileskey.Reason
url, and so on regardless of which fields are empty.
line.stripdestroyed leading tab information, so a URL-only row (titlecolumn empty) had its URL read into the title field instead of the link.
split("\t")did not preserve trailing empty fields, so a rowwith empty trailing columns lost its column alignment.
files:key intest/integration/test_text2feed.ymlmade themanual integration configuration ambiguous (YAML silently uses only the
last key).
Tests
All commands below were run in this environment (Ruby 3.3.6):
bundle exec rspec spec/plugins/subscription/text_spec.rb— 17 examples, 0 failuresbundle exec rake spec:plugins— 297 examples, 0 failuresbundle exec rake spec:lib— 110 examples, 0 failuresbundle exec rake spec— 416 examples, 0 failurestest/integration/test_text2feed.yml(singlefileskey, resolves to the two expected TSV paths) — exit 0
gem build automatic.gemspec— succeeded (automatic-26.09.gem)bundle exec ruby -Ilib -e "require 'automatic'"— exit 0bundle exec bin/automatic --version— exit 0, prints26.09bundle exec bin/automatic --help— exit 0Required CI (Ruby 3.3 / 3.4 / 4.0) status will be confirmed once the checks
run on this pull request.
Compatibility
titles/urls/feedsbehavior unchanged.FeedMakerunchanged.VERSIONremains26.09.Version History
Added one entry to the existing unreleased
v26.09section ofdoc/VERSIONS:https://claude.ai/code/session_01CbtimCQAVdGhaEFXsEGKPK
Generated by Claude Code