Fix file URI and CLI input boundary handling - #177
Merged
Conversation
Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_017Zn5VetozA4NmGEUGLGik1
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
StoreFilenow handsPublishAmazonS3the actual saved path as an absolute, percent-encodedfile:URI, instead of concatenating a possibly-relative path ontofile://(which could be misread as carrying an authority, and could not represent a path containing a space or other URI-reserved character).PublishAmazonS3now decodes the URI path back to a local filesystem path before uploading, undoing the percent-encodingStoreFileapplies.feedparsersubcommand now converts the URL validation failureAutomatic::Http.urialready applies into the CLI's ordinary failure path (stderr diagnostic, exit1), instead of letting it surface as an unprocessed exception with a backtrace.plugins/filter/join.rb's comment describingFeedMaker.create_pipeline's nil-link behavior no longer describes a code path this plugin doesn't call; it now just documents why this item's link is nil.Gemfilecomment for the Supported (external) plugin group no longer claims their specs exercise the external service directly rather than a double, which does not match how those specs are actually written.Compatibility
>= 3.3.0) and the CI matrix (3.3 / 3.4 / 4.0) are unchanged.ArgumentErrorraised from insideFeedParser.get_url(after URL validation passes) still propagates unconverted.Version History
doc/VERSIONS, which already describes fixing CLI contract drift; no new bullet was added for it.StoreFile/PublishAmazonS3handoff fix is recorded as one new v26.09 bullet: "Preserve local file paths when StoreFile hands file URIs to PublishAmazonS3."plugins/filter/join.rborGemfile, or for thedoc/PLUGINS.mdclarifications.Validation
spec/plugins/store/file_spec.rb,spec/plugins/publish/amazon_s3_spec.rb,spec/lib/automatic/cli_spec.rb): 45 examples, 0 failures.bundle exec rake spec): 423 examples, 0 failures (network spec not enabled).gem build automatic.gemspec: succeeded (version 26.09).require 'automatic': loads successfully.bin/automatic --version: exit 0.bin/automatic --help: exit 0.feedparseragainstfile:///etc/passwd,https:/feed, andhttp://[: each exits 1 with a one-lineautomatic:diagnostic on stderr and empty stdout.🤖 Generated with Claude Code
https://claude.ai/code/session_017Zn5VetozA4NmGEUGLGik1
Generated by Claude Code