Skip to content

fix(tests): future-proof click's isolated_filesystem - #47

Merged
Yannick-Dayer merged 1 commit into
mainfrom
fix/clicktest-tmp
Oct 28, 2026
Merged

Yannick-Dayer merged 1 commit into
mainfrom
fix/clicktest-tmp

Conversation

@Yannick-Dayer

@Yannick-Dayer Yannick-Dayer commented Oct 27, 2026 •

Copy link
Copy Markdown
Member

Click 9.0 will drop its isolated_filesystem test feature.

Implement our own CLI Runner with isolated_filesystem using tempfile.


📚 Documentation preview 📚: https://gridtk--47.org.readthedocs.build/en/47/

Click 9.0 will drop its isolated_filesystem test feature.
This implements our own CLI Runner with isolated_filesystem using tempfile.
@Yannick-Dayer Yannick-Dayer self-assigned this Oct 27, 2026
@Yannick-Dayer
Yannick-Dayer requested a review from anjos October 27, 2026 18:21
@github-actions

Copy link
Copy Markdown

Coverage report

This PR does not seem to contain any modification to coverable code.

@Yannick-Dayer
Yannick-Dayer enabled auto-merge (squash) October 27, 2026 19:30
@Yannick-Dayer
Yannick-Dayer requested review from sgaist and removed request for anjos October 28, 2026 10:44
@anjos

anjos commented Oct 28, 2026

Copy link
Copy Markdown
Member

This is a quite small and clean patch - no problem in merging it! Please go ahead, @Yannick-Dayer. Thanks @sgaist!

@anjos
anjos self-requested a review October 28, 2026 13:56
@Yannick-Dayer
Yannick-Dayer removed the request for review from sgaist October 28, 2026 13:56

@anjos anjos left a comment •

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks quite clean. Thanks @Yannick-Dayer.

@Yannick-Dayer
Yannick-Dayer merged commit 4c615cb into main Oct 28, 2026
11 checks passed
@Yannick-Dayer
Yannick-Dayer deleted the fix/clicktest-tmp branch October 28, 2026 13:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants