Skip to content

chore!: update minimal R version to R4.1.0, drop magrittr's pipe re-reexport - #2877

Open
maelle wants to merge 11 commits into
mainfrom
rversionyounger
Open

maelle wants to merge 11 commits into
mainfrom
rversionyounger

Conversation

@maelle

@maelle maelle commented Sep 3, 2026

Copy link
Copy Markdown
Contributor

Getting rid of the magrittr dependency is appealing.

Comment thread R/palette.R
#' add_layout_(with_fr()) %>%
#' set_vertex_attr("label", value = seq_len(gorder(.))) %>%
#' set_vertex_attr("size", value = 10) %>%
#' fw <- foodwebs[[1]]

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

rewritten because of the .

Comment thread R/iterators.R
#' g <- sample_gnp(20, 3 / 20) %>%
#' set_edge_attr("weight", value = rnorm(gsize(.)))
#' g <- sample_gnp(20, 3 / 20)
#' g <- set_edge_attr(g, "weight", value = rnorm(gsize(g)))

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

rewritten because of the .

@github-actions

github-actions Bot commented Sep 3, 2026

Copy link
Copy Markdown
Contributor

This is how benchmark results would change (along with a 95% confidence interval in relative change) if 5741ef3 is merged into rversion:

  • ✔️as_adjacency_matrix: 696ms -> 698ms [-1.7%, +2.17%]
  • ✔️as_biadjacency_matrix: 717ms -> 709ms [-3.72%, +1.37%]
  • ✔️as_data_frame_both: 1.46ms -> 1.45ms [-2.93%, +2.58%]
  • ✔️as_long_data_frame: 3.44ms -> 3.42ms [-3.25%, +2.48%]
  • ✔️es_attr_filter: 2.24ms -> 2.27ms [-1.89%, +3.92%]
  • ✔️graph_from_adjacency_matrix: 140ms -> 139ms [-1.56%, +0.98%]
  • ✔️graph_from_data_frame: 3.23ms -> 3.19ms [-2.99%, +1.05%]
  • ✔️vs_attr_filter: 1.34ms -> 1.3ms [-5.66%, +0.05%]
  • ❗🐌vs_by_name: 827µs -> 858µs [+0.86%, +6.62%]
    Further explanation regarding interpretation and methodology can be found in the documentation.

Comment thread R/igraph-package.R Outdated
#' add_edges(c(1, 6)) |>
#' plot()
NULL
`%>%` <- function(lhs, rhs) {

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's just drop it and see what revdepchecks suggest.

Base automatically changed from rversion to main September 10, 2026 08:54
@maelle maelle changed the title chore: update minimal R version to R4.1.0 chore!: update minimal R version to R4.1.0, drop magrittr's pipe re-reexport Sep 15, 2026
@github-actions

Copy link
Copy Markdown
Contributor

This is how benchmark results would change (along with a 95% confidence interval in relative change) if 4b15fff is merged into main:

  • ✔️as_adjacency_matrix: 244ms -> 243ms [-0.8%, +0.11%]
  • ✔️as_biadjacency_matrix: 260ms -> 259ms [-0.89%, +0.5%]
  • ✔️as_data_frame_both: 261ms -> 263ms [-0.53%, +1.66%]
  • ✔️as_long_data_frame: 208ms -> 208ms [-0.52%, +0.33%]
  • 🚀es_attr_filter: 244ms -> 243ms [-0.72%, -0.03%]
  • 🚀graph_from_adjacency_matrix: 274ms -> 272ms [-0.72%, -0.04%]
  • ✔️graph_from_data_frame: 278ms -> 278ms [-0.4%, +0.82%]
  • 🚀vs_attr_filter: 331ms -> 324ms [-2.78%, -1.45%]
  • 🚀vs_by_name: 312ms -> 310ms [-0.89%, -0.12%]
    Further explanation regarding interpretation and methodology can be found in the documentation.

@github-actions

Copy link
Copy Markdown
Contributor

This is how benchmark results would change (along with a 95% confidence interval in relative change) if 6991c6c is merged into main:

  • ✔️as_adjacency_matrix: 244ms -> 242ms [-2.52%, +0.68%]
  • ✔️as_biadjacency_matrix: 254ms -> 255ms [-0.83%, +1.32%]
  • ✔️as_data_frame_both: 260ms -> 262ms [-0.44%, +2.37%]
  • ✔️as_long_data_frame: 207ms -> 207ms [-1.23%, +0.46%]
  • ✔️es_attr_filter: 244ms -> 242ms [-1.85%, +0.11%]
  • ✔️graph_from_adjacency_matrix: 271ms -> 270ms [-1.34%, +0.71%]
  • ❗🐌graph_from_data_frame: 273ms -> 277ms [+0.26%, +2.93%]
  • 🚀vs_attr_filter: 324ms -> 316ms [-3.27%, -1.8%]
  • ✔️vs_by_name: 308ms -> 308ms [-1.73%, +2.14%]
    Further explanation regarding interpretation and methodology can be found in the documentation.

@github-actions

Copy link
Copy Markdown
Contributor

This is how benchmark results would change (along with a 95% confidence interval in relative change) if a9cbd09 is merged into main:

  • ✔️as_adjacency_matrix: 242ms -> 242ms [-0.4%, +0.5%]
  • ✔️as_biadjacency_matrix: 254ms -> 254ms [-0.83%, +0.47%]
  • ✔️as_data_frame_both: 258ms -> 259ms [-0.13%, +0.93%]
  • ✔️as_long_data_frame: 207ms -> 207ms [-0.73%, +0.27%]
  • ✔️es_attr_filter: 243ms -> 243ms [-0.35%, +0.23%]
  • ✔️graph_from_adjacency_matrix: 270ms -> 270ms [-0.5%, +0.16%]
  • ✔️graph_from_data_frame: 274ms -> 275ms [-0.04%, +1.21%]
  • 🚀vs_attr_filter: 326ms -> 316ms [-3.4%, -2.34%]
  • ✔️vs_by_name: 306ms -> 305ms [-1.05%, +0.28%]
    Further explanation regarding interpretation and methodology can be found in the documentation.

@github-actions

Copy link
Copy Markdown
Contributor

This is how benchmark results would change (along with a 95% confidence interval in relative change) if b1cf6b5 is merged into main:

  • ✔️as_adjacency_matrix: 260ms -> 260ms [-1.48%, +1.11%]
  • ✔️as_biadjacency_matrix: 278ms -> 278ms [-1.21%, +1.59%]
  • ✔️as_data_frame_both: 272ms -> 271ms [-1.42%, +0.65%]
  • ✔️as_long_data_frame: 221ms -> 221ms [-1.54%, +1.5%]
  • ✔️es_attr_filter: 260ms -> 255ms [-3.41%, +0.06%]
  • ✔️graph_from_adjacency_matrix: 301ms -> 297ms [-3.41%, +1.17%]
  • ✔️graph_from_data_frame: 291ms -> 291ms [-0.76%, +1.38%]
  • 🚀vs_attr_filter: 347ms -> 336ms [-3.67%, -2.21%]
  • ❗🐌vs_by_name: 322ms -> 324ms [+0.02%, +1.35%]
    Further explanation regarding interpretation and methodology can be found in the documentation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants