ext/filter: encode 0xFF in FILTER_SANITIZE_ENCODED#165
Closed
iliaal wants to merge 1 commit into
Closed
Conversation
php_filter_encode_url initialized the "must encode" bitmap with memset(tmp, 1, sizeof(tmp) - 1), leaving tmp[255] unset. On common stacks that byte stayed zero, so 0xFF was copied through unencoded. Initialize the full 256-byte table so every non-allowlisted byte is percent-encoded.
iliaal
force-pushed
the
filter-sanitize-encoded-0xff
branch
from
July 16, 2026 11:26
06a9292 to
c8bb763
Compare
Owner
Author
|
Submitted upstream as php#22762. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
php_filter_encode_urlinitialized the encode bitmap withmemset(tmp, 1, sizeof(tmp) - 1), leavingtmp[255]unset. On common stacks that byte stayed zero, so0xFFwas copied through unencoded underFILTER_SANITIZE_ENCODED.Initialize the full 256-byte table so every non-allowlisted byte is percent-encoded.