Repository navigation
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Mutating a draft Map during iteration can visit deleted entries and skip added entries when no earlier operation has created the draft's copy.
Previously
seenwas[["a", 1], ["b", undefined]]; it now matches native Map behavior:[["a", 1], ["c", 3]].Prepare the copy before
forEachandkeysstart iterating, so iteration and subsequent mutations use the same backing Map. This also fixesvalues,entries, andSymbol.iterator, which usekeys. Read-only iteration now creates a shallow copy, but an unmodified producer still returns the original state. The regression cases cover all five entry points in the existing configuration matrix.This restores native live-iteration semantics: repeatedly deleting and re-adding the current key, or continually adding keys during traversal, can keep iteration running just as it would on a plain Map.