fix: retry on GOAWAY errors when using cached HTTP/2 connections#491
fix: retry on GOAWAY errors when using cached HTTP/2 connections#4910xuLiang wants to merge 1 commit into
Conversation
RoundTripOnlyCachedConn bypasses the retry loop in RoundTripOpt, so GOAWAY and other retryable errors were returned directly to callers. Now we check CanRetryError before returning, allowing retryable errors to fall through and create a new connection. Changes: - Export canRetryError as CanRetryError - Check CanRetryError in roundTrip when RoundTripOnlyCachedConn fails
|
I could not wait for a tagged release. If you need a release with the above fix you can get it from github.com/bertold/req v3.57.2 - note that this repo is a hard fork. |
I checked in |
Thanks for opening the PR. It has been merged. New version released. I also sent you an invite to be a collaborator on that repo. |
RoundTripOnlyCachedConn bypasses the retry loop in RoundTripOpt, so GOAWAY and other retryable errors were returned directly to callers.
Now we check CanRetryError before returning, allowing retryable errors to fall through and create a new connection.
Changes:
Fixes #376