Skip to content

chore: use new order-stream filter from sdk#3

Merged
Fraser999 merged 2 commits into
mainfrom
fraser/eng-1789/order-stream-filter
May 8, 2026
Merged

chore: use new order-stream filter from sdk#3
Fraser999 merged 2 commits into
mainfrom
fraser/eng-1789/order-stream-filter

Conversation

@Fraser999
Copy link
Copy Markdown
Contributor

@Fraser999 Fraser999 commented May 5, 2026

[Claude Code]

Summary

Replaces hand-rolled tx_cache.stream_orders() loops with OrderStreamExt::filter_orders from signet-sdk's new stream-combinators module (ENG-1789).

Changes

  • Cargo.toml - bumped signet-{constants,orders,tx-cache,types,zenith} to 0.16.3.
  • crates/tracker-server/Cargo.toml - added signet-orders dep so the server can import OrderStreamExt.
  • crates/tracker-server/src/ingestion/order_discovery.rs - poll_cache uses filter_orders with a stateful predicate that records every hash into current_hashes and returns true only for newly-seen ones, then try_collects the new orders. Same observable behavior, fewer moving parts.
  • crates/tracker-server/src/ws/handlers.rs - single-order WS lookup uses filter_orders + try_next instead of a manual while let with a hash check.
  • crates/tracker/src/order_tracker.rs - fetch_order rewritten the same way.
  • CLAUDE.md - added signet-orders to the tracker-server dependency list.

Copy link
Copy Markdown
Contributor Author

This stack of pull requests is managed by Graphite. Learn more about stacking.

@Fraser999 Fraser999 changed the title use new order-stream filter from sdk chore: use new order-stream filter from sdk May 5, 2026
@Fraser999 Fraser999 marked this pull request as ready for review May 7, 2026 11:34
@Fraser999 Fraser999 requested a review from a team as a code owner May 7, 2026 11:34
Copy link
Copy Markdown
Member

@Evalir Evalir left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, this looks super clean now

@Fraser999 Fraser999 merged commit 99c804e into main May 8, 2026
8 checks passed
@Fraser999 Fraser999 deleted the fraser/eng-1789/order-stream-filter branch May 8, 2026 10:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants