Skip to content

feat: add write-only secrets attributes for webhook resources - #3631

Draft
tdyas wants to merge 2 commits into
integrations:mainfrom
temporalio:webhook_write_only_secrets
Draft

feat: add write-only secrets attributes for webhook resources#3631
tdyas wants to merge 2 commits into
integrations:mainfrom
temporalio:webhook_write_only_secrets

Conversation

@tdyas

@tdyas tdyas commented Sep 3, 2026

Copy link
Copy Markdown

Resolves #3628


Before the change?

  • The github_repository_webhook and github_organization_webhook resources currenrly only support a secret attribute to set the webhook's secret. This secret is persisted in Terraform state which is suboptimal from a security perspective.

After the change?

  • In addition to a secret attribute, github_repository_webhook and github_organization_webhook now support a write-only secret_wo attribute (and related secret_wo_version attribute for triggering updates) as per conventions used in other Terraform providers. Terraform's ephemeral resources support can now be used together with the write-only secret_wo attribute to ensure webhook secrets are never persisted in Terraform state.

Pull request checklist

  • Schema migrations have been created if needed (example)
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been reviewed and added / updated if needed (for bug fixes / features)

Does this introduce a breaking change?

No. The new secret_wo and secret_wo_version fields were added and the secret field remains in place and available for use by users. The two schemes are marked as conflicting in the schema so Terraform and logic in this PR should prevent users from trying to use both schemes.

Please see our docs on breaking changes to help!

  • Yes
  • No

@github-actions

github-actions Bot commented Sep 3, 2026

Copy link
Copy Markdown

👋 Hi, and thank you for this contribution!

This repo is maintained by GitHub and community members on a best-effort basis. We'll get to this as soon as we can.

You can help us prioritize by joining the discussion on open issues and PRs, sharing details on the changes you need, and reviewing other contributions.


🤖 This is an automated message.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[FEAT]: support write-only secrets attributes for webhook resources

1 participant