Fix incorrect fan speed query error being reported - #23117
Closed
kweronsx wants to merge 1 commit into
Closed
Conversation
KFilipek
reviewed
Sep 8, 2026
Comment on lines
1474
to
1479
| @@ -1479,7 +1474,8 @@ | |||
| auto result = ze2urResult(ZE_CALL_NOCHECK( | |||
Contributor
There was a problem hiding this comment.
I believe it should be more readable.
Suggested change
| auto result = ze2urResult(ZE_CALL_NOCHECK( | |
| const auto ZeResult = ZE_CALL_NOCHECK( | |
| zesFanGetState, (Fan, ZES_FAN_SPEED_UNITS_PERCENT, &CurSpeed)); | |
| if (ZeResult == ZE_RESULT_ERROR_UNSUPPORTED_FEATURE || | |
| ZeResult == ZE_RESULT_ERROR_NOT_AVAILABLE) | |
| return UR_RESULT_ERROR_UNSUPPORTED_ENUMERATION; | |
| if (ZeResult != ZE_RESULT_SUCCESS) | |
| return ze2urResult(ZeResult); |
Contributor
Author
There was a problem hiding this comment.
Ok. I couldn't apply your suggestion directly due to some web error, but I did apply it manually.
kweronsx
force-pushed
the
fix-fanspeed-issue
branch
from
September 8, 2026 12:16
6951083 to
c668cab
Compare
kswiecicki
approved these changes
Sep 8, 2026
Contributor
Author
|
Closing this because the change was already implemented: #23113 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change fixes this CI error:
