Repository navigation
CORE-8562: Restore page titles and navigation from cached pages and drawers - #2811
Merged
Merged
Conversation
shawnm0705
approved these changes
Nov 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Story/Ticket Reference ID from JIRA:
CORE-8562
Changes:
Returning from Events, cached Reviews, or Notifications could retain another page's browser title. Restore the selector title on successful routing, preserve the underlying title when Notifications is a drawer, and restore the active desktop review's selected name or empty-list title without letting cached views overwrite other pages.
Settings now waits for drawer dismissal before opening badges. Full-page Notifications returns to the mobile header's recorded originating route, preserving query parameters and fragments, or falls back to Home for direct entry. Explicit routing replaces the Notifications entry so cached direct visits cannot send the user outside the app through browser-history inference.
Follow-up to #2810. Includes regression tests for the reported navigation failures. Populated reviewer testing also exposed absent submissionId parameters becoming NaN and clearing the selected review on refresh. Normalize the base-route parameter and preserve the selected review across cached refreshes, while retaining advancement after completion.
Validation:
Checklist:
Latest full local Safari navigation pass: