Skip to content

CORE-8562: Restore page titles and navigation from cached pages and drawers - #2811

Merged
trtshen merged 4 commits into
login-refactorfrom
fix/CORE-8562-experience-selector-title
Nov 16, 2026
Merged

trtshen merged 4 commits into
login-refactorfrom
fix/CORE-8562-experience-selector-title

Conversation

@trtshen

@trtshen trtshen commented Nov 16, 2026 •

Copy link
Copy Markdown
Collaborator

Story/Ticket Reference ID from JIRA:
CORE-8562

Changes:
Returning from Events, cached Reviews, or Notifications could retain another page's browser title. Restore the selector title on successful routing, preserve the underlying title when Notifications is a drawer, and restore the active desktop review's selected name or empty-list title without letting cached views overwrite other pages.

Settings now waits for drawer dismissal before opening badges. Full-page Notifications returns to the mobile header's recorded originating route, preserving query parameters and fragments, or falls back to Home for direct entry. Explicit routing replaces the Notifications entry so cached direct visits cannot send the user outside the app through browser-history inference.

Follow-up to #2810. Includes regression tests for the reported navigation failures. Populated reviewer testing also exposed absent submissionId parameters becoming NaN and clearing the selected review on refresh. Normalize the base-route parameter and preserve the selected review across cached refreshes, while retaining advancement after completion.

Validation:

  • All 121 affected Notifications, Settings, desktop Reviews, header and route-title tests pass in the local container using a temporary scoped TypeScript configuration. New regressions were observed failing before their fixes.
  • Local Angular development server rebuilt successfully; git diff whitespace checks pass.
  • Safari verified Home/Events Notifications drawers, Events → browser Back → Reviews, Settings drawer → Badges (drawer gone), Badges → routed Settings, Due Status/Events transitions, and cached direct-entry Notifications → Back → Home.
  • The selector showed Experiences - Practera while loading, then automatically selected the account's sole experience. Unit tests cover repeated selector navigation.
  • Additional Safari verification with a dedicated local mentor and two real pending reviews: selected-review switching, HTML-entity decoding, three Home → browser Back cycles retaining Review B, Due Status → Reviews sidebar return, and Notifications open/close preserving the selected title. Learner response and reviewer feedback fields rendered. This run reproduced an additional selection-reset bug before the follow-up fix and passed afterward.
  • Safari coverage limits: the local selector has only one experience and automatically returns Home. Narrow-screen desktop Safari checks do not verify the mobile-device Notifications path. Actual ngOnDestroy timing is not established by these navigation checks.
  • Full npm test remains blocked at compilation by existing missing directUrl fixtures in file-display (57, 84), file-upload (96), auth.service (120, 159, 220, 259), plus incomplete ProgramObj in experiences.page.spec.ts (126).
  • Existing CI scan reports 75 historical Gitleaks findings. The tracked-but-gitignored-file check passes. No security-scan exception or history rewrite was added.
  • Independent read-only review found no actionable correctness issues.

Checklist:

  • Targeted regression tests completed.
  • Safari checks completed for all four follow-up defects; account/data coverage limits recorded above.
  • Verification results recorded in this PR.
  • Full-suite/CI baseline blockers resolved (outside this change).

Latest full local Safari navigation pass:

  • Tested both local reviewer and learner accounts with URL and title assertions: 88 checks passed. No stale-title failure reproduced.
  • Populated Reviews A/B, HTML-entity titles, repeated Home → Back → Forward, Due Status/sidebar returns, Notifications and Settings drawers, badges and routed Settings, direct/cached Notifications Back fallback, Events categories, Home, experience-selector links, activity topics and learner assessment navigation.
  • Direct Messages loaded successfully in this run. Three Messages ↔ Events Back/Forward cycles and Messages → Home passed.
  • Responsive Design Mode at 390 × 844: Events, Due Status, Settings, badges and drawers passed. Returned Safari to normal desktop view afterward.
  • One separate selection observation: Review B → Home → Back → Forward → sidebar Reviews resets to Review A; the displayed review and browser title agree. The initial expectation of retaining B failed, then this sequence was repeated and confirmed title/content agreement. Do not count this as persistent-selection verification.
  • No application code changes were needed for this verification pass; local reviewer fixtures remain available. Browser left on learner Home.

@trtshen trtshen changed the title CORE-8562: Restore experience selector title after Events navigation CORE-8562: Restore page titles and navigation from cached pages and drawers Nov 16, 2026
@trtshen trtshen self-assigned this Nov 16, 2026
@trtshen
trtshen requested a review from shawnm0705 November 16, 2026 04:28
@trtshen
trtshen enabled auto-merge November 16, 2026 04:28
@trtshen
trtshen merged commit 2e21316 into login-refactor Nov 16, 2026
1 check failed
@trtshen
trtshen deleted the fix/CORE-8562-experience-selector-title branch November 16, 2026 06:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants