test(ios): correct testing app bundle id to io.invertase.testing - #9131
Open
russellwheatley wants to merge 7 commits into
Open
test(ios): correct testing app bundle id to io.invertase.testing#9131russellwheatley wants to merge 7 commits into
russellwheatley wants to merge 7 commits into
Conversation
com.invertase.testing is not registered on the team's Apple Developer Portal (io.invertase.testing is), so Xcode cannot provision the app. Updates the Xcode project's PRODUCT_BUNDLE_IDENTIFIER, keychain-access-groups entitlement, and the Google Sign-In URL scheme, and re-downloads GoogleService-Info.plist for the io.invertase.testing Firebase iOS app so Firebase/Google services keep working under the corrected bundle id.
Contributor
|
Caution The consumer version of Gemini Code Assist on GitHub has been sunset. All code review activity has officially ceased. |
russellwheatley
changed the title
russellwheatley
changed the title
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #9131 +/- ##
============================================
+ Coverage 66.13% 66.96% +0.84%
============================================
Files 497 363 -134
Lines 39153 28413 -10740
Branches 5799 4356 -1443
============================================
- Hits 25889 19024 -6865
+ Misses 11793 8691 -3102
+ Partials 1471 698 -773
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
….plist The iOS bundle id change in this PR regenerated GoogleService-Info.plist with a new GOOGLE_APP_ID, but tests/globals.js still had the old value hardcoded, causing app.e2e.js config assertions and App Check token tests to fail in CI.
…esting bundle id testing.entitlements now grants keychain-access-groups for io.invertase.testing (not com.invertase.testing), so the e2e test must request the matching YYX2P3XVJ7.io.invertase.testing group or useUserAccessGroup() fails with auth/keychain-error.
The config-switch e2e case re-enabled the debug provider without a debugToken on iOS, so exchangeDebugToken could not use the shared CI token after App Attest failed.
Keep CI/local simulator cleanup aligned with the testing app bundle id change from com.invertase.testing.
…sting Match triage notes and benign Detox noise examples to the corrected testing app bundle identifier.
russellwheatley
changed the title
Post-suite simctl get_app_container still used the Android applicationId after the iOS testing bundle id change, so CI failed after Jet passed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
com.invertase.testing) is not registered on the team's Apple Developer Portal, onlyio.invertase.testingis, so Xcode cannot provision/build the app for on-device testing.PRODUCT_BUNDLE_IDENTIFIERintests/ios/testing.xcodeproj/project.pbxproj, thekeychain-access-groupsentitlement, and the Google Sign-In URL scheme inInfo.plistto match.GoogleService-Info.plistfor theio.invertase.testingFirebase iOS app so Firebase/Google Sign-In config matches the corrected bundle id.com.invertase.testingreferences intests/e2e/firebase.test.js(simulator app-container/listapps checks). Android identifiers are untouched since the AndroidapplicationId/package namespace is a separate, unaffected value.