Closed
Clear tmp directory when switching controller versions#698
Conversation
Co-authored-by: Apollon77 <11976694+Apollon77@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Clear tmp directory when switching controller versions
Clear tmp directory when switching controller versions
Nov 8, 2025
Contributor
|
Manuell in Änderungen gegenüber diesem PR:
Danke! |
GermanBluefox
added a commit
that referenced
this pull request
Sep 6, 2026
Track the installed js-controller version in `<testDir>/.controller-version` and empty `node_modules`, the data dir and the log dir when the requested version differs from the one used in the previous run. Otherwise leftover files and stale states of the old version can break the test run. Implements #698 with the following adjustments: - The version is tracked after the Node.js-dependent default resolution, so switching between Node 20 (7.2.2) and Node 22+ (dev) is detected too - The log directory is cleared as well - Reading/writing the version file never fails the test run - The version is only stored after a successful installation Closes #526 Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01EQZhzwNsGRdbQrL3TH53tS
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When integration tests switch between controller versions (e.g.,
dev→latest), leftovernode_modulesand data directories cause version conflicts and stale state.Changes
Version tracking via
.controller-versionfile:getInstalledControllerVersion()- reads current version from tracking filesaveControllerVersion()- persists version after installationgetControllerVersionFilePath()- returns path to tracking fileAutomatic cleanup on version change:
clearTmpDirectory()- emptiesnode_modulesand data directoriesprepareTestDir()- detects version changes and clears before installationBehavior
Version changes trigger cleanup; same version preserves state for faster subsequent runs.
Original prompt
💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.