chore(i18n, v5): rename archived v5 pages to .mdx - #4708
Open
thetaPC wants to merge 1 commit into
Open
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue URL: https://ionic-cloud.atlassian.net/browse/FW-6456
What is the current behavior?
The archived v5 docs on this branch are still
.md. Docusaurus's Strict MDX guidance asks for.mdx, and v5 is the last tree that has to move before the transitional.mdshims in the component API plugin can be removed.What is the new behavior?
The jp companion to #4700. Same tree, same result.
versioned_docs/version-v5renamed. v5 has noREADME.mdand nostatic/usage/v5, so the whole tree moves.Unlike v6 and v7, this one fixes nothing. v5's
native/andcli/commandspages are committed rather than generated, so the tree was already internally consistent and none of its links pointed at anything that had moved. The build is warning for warning identical to the base branch.versions.jsonis not in this PR, so v5 stays archived and nothing about the deployed site changes. Refer to the testing steps below to build it locally.Does this introduce a breaking change?
Other information
The v5 link and import graph matches #4700 entry for entry across all 460 files.
The generation scripts do not write to v5 and this PR does not change that. Adding v5 to them writes 24
.mdxover the 191 committednative/pages, which produces duplicate routes and silently drops the build from 460 pages to 286.How to test
v5 is archived, so a normal build skips it. To build it:
"v5"toversions.json:["v8", "v5"]npm run buildcouldn't be resolvedwarnings. 460 is also the number of pages tracked in the tree, which is the check that the 191native/and 53cli/commandspages came through.versions.jsonSpot check
/docs/v5/api/accordionand/docs/v5/native/camera, one hand-written page and one of the committed native pages.