Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
brandyscarney
approved these changes
Apr 7, 2026
Member
brandyscarney
left a comment
brandyscarney
left a comment
There was a problem hiding this comment.
Looks good! Please update the PR title before merging. 🙂
OS-jacobbell
changed the title
ShaneK
requested changes
Apr 7, 2026
Member
ShaneK
left a comment
ShaneK
left a comment
There was a problem hiding this comment.
Looking really good! A couple of minor concerns, though
ShaneK
approved these changes
Apr 13, 2026
Member
ShaneK
left a comment
ShaneK
left a comment
There was a problem hiding this comment.
Awesome work! Looks good to me 🚀
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue number: resolves #31052
What is the current behavior?
After a page navigation, ion-checkbox's
onslotchangeevent fires before the element'stextContenthas been updated. It is called again aftertextContentbecomes readable on Safari, but is not called again after thetextContentbecomes readable on Chrome and Firefox.What is the new behavior?
MutationObserverinstead ofonslotchangeand fires specifically on character data changes. This ensureshasLabelContentis up to date.MutationObserverdoes not fire on load, sohasLabelContentis initialized inconnectedCallbackDoes this introduce a breaking change?