feat(animations): set smother animations for modal in ionic#31082
Open
os-davidlourenco wants to merge 2 commits intonextfrom
Open
feat(animations): set smother animations for modal in ionic#31082os-davidlourenco wants to merge 2 commits intonextfrom
os-davidlourenco wants to merge 2 commits intonextfrom
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
os-davidlourenco
added
package: core
github-actions
bot
removed
package: angular
os-davidlourenco
force-pushed
the
ROU-12702
branch
from
9c1160c to
e403a3a
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue number: resolves internal
What is the current behavior?
The animations are only defined for iOS and md, and the Ionic theme uses the md animations.
What is the new behavior?
New animation files for Ionic were added to each component that uses animations, based on the md file.
The new Ionic animation file for the modal includes changes to the transitions.
Changes in the gestures for the modal, only for the Ionic theme.
Does this introduce a breaking change?
Other information