Repository navigation
Conversation
thetaPC
added this pull request to stack #31629
October 24, 2026 03:07
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue number: resolves internal
What is the current behavior?
Buttons only have bold colors. Unlike chip and badge, which also have a
colorprop, there's nohueprop for muted colors.What is the new behavior?
hueprop toion-button. It reads the prop first, thenIonButton.huein the theme config, and defaults tobold, like chiphue.subtleto the recipe in every theme, with the same fills, states,semanticcolors, ripple and disabled styles asboldcontrasttextforegroundtext and a subtleshadeborder. md keeps its neutral 12% borderforegroundtextforeground, and text on an opaque fill of the color usescontrast, matchingion-textand FW-6422Does this introduce a breaking change?
Other information
Why these choices
#D9E5FCfor primary), measured from the kit and from a nativeUIButtonin its tinted configuration. The shared palette (#EBF1FD) matches ios chips and badges, works for everycolorand follows the palette in dark mode. iOS 17's value would make subtle buttons darker than the subtle chips beside themKnown gaps
light,warningandsuccesstext fails WCAG's 4.5:1 on white, the same as in subtle chips. The colors come from the shared palette, so the fix belongs there (FW-6417)ion-buttonsand toolbar migrations can add their ownHow to test