Repository navigation
fix(vue-router): hide back button on reset tab root - #31653
Open
michaelkhabarov wants to merge 1 commit into
Open
michaelkhabarov wants to merge 1 commit into
michaelkhabarov wants to merge 1 commit into
Conversation
Tapping the active tab resets it with router.go(), which leaves the tab's child as the last route in its stack. Switching to another tab and back then copied the child's pushedByRoute onto the tab root, so the root showed a back button. Copy pushedByRoute only when the last route in the stack is the page the tab returns to. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
@michaelkhabarov is attempting to deploy a commit to the Ionic Team on Vercel. A member of the Team first needs to authorize it. |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What is the current behavior?
Tapping the active tab button resets the tab with
router.go(), which leaves the tab's child as the last route in the tab stack. When the user then switches to another tab and back, the router copiespushedByRoutefrom that child onto the tab root, so the root page getscan-go-backand shows a back button with nowhere sensible to go./tabs/tab1and navigate to a child page./tabs/tab1./tabs/tab1now shows a back button (visible when the button has nodefaultHref).What is the new behavior?
pushedByRouteis copied only when the last route in the tab stack is the page the tab returns to, so a reset tab root no longer shows a back button.tabs.spec.tsthat follows the steps above. Without the fix it fails on the tab1 root havingion-page can-go-back.Does this introduce a breaking change?