Repository navigation
fix(vue-router): reset tab after other tab reset - #31654
Open
michaelkhabarov wants to merge 1 commit into
Open
michaelkhabarov wants to merge 1 commit into
michaelkhabarov wants to merge 1 commit into
Conversation
Tapping the active tab resets it with router.go(). When another route is pushed after that, the browser drops every history entry after it, including the root of a tab whose child is pushed next. The first entry of that tab's stack is then ahead of the current position, so tapping the tab button called router.go() with a positive delta and nothing happened. Replace the current entry with the tab root in that case, as the tab already does when its first entry is the current one. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
@michaelkhabarov is attempting to deploy a commit to the Ionic Team on Vercel. A member of the Team first needs to authorize it. |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What is the current behavior?
Tapping the active tab button resets the tab with
router.go(). When another tab is reset this way and the user then switches to a tab whose child page is restored, that push drops the browser history entry of the tab root. The first route in the tab stack is now ahead of the current history position, so tapping the tab button again callsrouter.go()with a positive delta and nothing happens./tabs/tab1and navigate to a child page./tabs/tab1./tabs/tab2.What is the new behavior?
tabs.spec.tsthat follows the steps above. Without the fix it fails because the tab2 root stays hidden.Does this introduce a breaking change?