Fix: Check returned STDERR and STDOUT in validation tests#3502
Open
ipspace wants to merge 2 commits into
Open
Conversation
Some versions of Arista EOS return error messages on stderr. SSH client sends those messages to (local) stderr, and the validation code did not get them. This fix combines stderr and stdout returned by SSH (or docker exec) into a single string that can be checked by the validation code. Fixes #3496
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
jbemmel
reviewed
Jun 20, 2026
| CAPTURED_STDERR: str = '' | ||
|
|
||
| def get_combined_output() -> str: | ||
| global CAPTURED_STDOUT, CAPTURED_STDERR |
Collaborator
There was a problem hiding this comment.
global not needed here, only when the value is changed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Some versions of Arista EOS return error messages on stderr. SSH client sends those messages to (local) stderr, and the validation code did not get them. This fix combines stderr and stdout returned by SSH (or docker exec) into a single string that can be checked by the validation code.
Fixes #3496