Repository navigation
Preserve nested Dict error context - #999
Open
ViktorBystrov72 wants to merge 1 commit into
Open
ViktorBystrov72 wants to merge 1 commit into
ViktorBystrov72 wants to merge 1 commit into
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests.
☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Identify the offending key when
Dict(per_key_traits=...)rejects a value, and preserve the expected type through nested dictionaries and containers. A bad string inside a nested dictionary is no longer reported as a dictionary that must be a dictionary; errors involving a list retain the list context.Regression cases cover the reported schema, nested dictionaries and lists, custom
TraitErrormessages, and the existing fallbackvalue_traitdiagnostics.Related to the closed #978, which added an outer key label while leaving nested diagnostics outside its scope. This change carries the existing
TraitErrorcontext through the per-key validation path.Fixes #920.
AI assistance: Codex assisted with the implementation and regression tests. 🤖🤖