Repository navigation
In get_connection, opt for if/else over superfluous try/except block #831
Description
Here,
python-irodsclient/irods/pool.py
Line 85 in d3cbda0
If however KeyError were raised from other sources, due either to unforeseen problems with the code as-is or future developments of the Pool.get_connection method, this approach could go sideways, resulting in the new connection code being executed for potentially the wrong reasons.
if/else is more direct and less likely to fail.
See this PR to view the code changes being spoken of here.
Activity
[-]In `get_connection`, opt for if/else over superfluous try/except blocks[/-][+]In `get_connection`, opt for if/else over superfluous try/except block[/+][irods#831] Use if-else instead of try-except to avoid issues with Ke…
[#831] Use if-else instead of try-except to avoid issues with KeyError
korydraughn commentedon Oct 2, 2026
The work for this issue was completed by @glyg.
Closing.