Repository navigation
Conversation
korydraughn
left a comment
korydraughn
left a comment
There was a problem hiding this comment.
Wording seems good.
Are we encouraging the use of irods.helpers and make_session()?
Are they meant for general usage?
d-w-moore
changed the title
I don't feel we have to encourage it ... if the mention of it as the first option seems like encouraging, perhaps a reorganization is needed. The upshot is: a client environment set up, There is this: |
|
Ok, I think we're now presenting the different instance creation options fairly and on equal ground. |
|
Are new commits on the way? Nothing has changed since I last looked at this PR. |
Yeah, sorry ... concentration lapse. I have just now put in the changes referred to aboe. |
|
|
||
| One way of starting a session is to pass iRODS credentials as keyword | ||
| An `iRODSSession` instance is the interface object through which iRODS server | ||
| APIs can be invoked. One can create the object using constructor form directly, |
There was a problem hiding this comment.
| APIs can be invoked. One can create the object using constructor form directly, | |
| APIs can be invoked. One can create the object using the constructor form directly, |
There was a problem hiding this comment.
Resolving this since new commits have caused this to be labeled as outdated.
There was a problem hiding this comment.
Ignore my last comment.
| Once created, the `iRODSSession` instance can be managed from a choice between two | ||
| possible patterns. Firstly, one can allow references to the instance to persist as | ||
| is natural for the application. This allows Python interpreter's reference counting to | ||
| let the object pass out of scope and destroy the underlying server connection(s) at the | ||
| proper time: | ||
|
|
||
| ```python | ||
| home_coll = session.collections.get(f'/tempZone/home/{session.username}') | ||
| # (... Further instances of calls to the server through 'session' may follow.) | ||
| ``` |
There was a problem hiding this comment.
The code block on line 68 seems out of place in relation to the text on line 62.
Feels like the code block can be removed entirely?
| @@ -41,7 +41,62 @@ Uninstalling | |||
| Establishing a (secure) connection | |||
There was a problem hiding this comment.
This title includes (secure), but SSL/TLS isn't mentioned until the next section.
Consider whether (secure) should be moved or removed?
There was a problem hiding this comment.
I think I've corrected this and all the above concerns. If so, let me know and I'll resolve conversations
Co-authored-by: Terrell Russell <terrellrussell@gmail.com>
| Note that if the `client_zone` parameter is not provided, the `zone` parameter is used in its place. | ||
|
|
||
| Using environment files (including any SSL settings) in `~/.irods/`: | ||
| We can also name an environment file (including settings both SSL and non-SSL related) to be used in |
There was a problem hiding this comment.
... (including settings both SSL and non-SSL related) ...
This phrasing is a bit hard to understand. Consider rewording it.
|
@d-w-moore Please mark any review comments that have been addressed as resolved. |
3 participants
No description provided.