Complete EVPN Fabric sample and reconciliation support - #528
Open
felix-kaestner wants to merge 8 commits into
Open
Complete EVPN Fabric sample and reconciliation support#528felix-kaestner wants to merge 8 commits into
felix-kaestner wants to merge 8 commits into
Conversation
Signed-off-by: Felix Kästner <felix.kaestner@sap.com>
Signed-off-by: Felix Kästner <felix.kaestner@sap.com>
Signed-off-by: Felix Kästner <felix.kaestner@sap.com>
Signed-off-by: Felix Kästner <felix.kaestner@sap.com>
Signed-off-by: Felix Kästner <felix.kaestner@sap.com>
Signed-off-by: Felix Kästner <felix.kaestner@sap.com>
Signed-off-by: Felix Kästner <felix.kaestner@sap.com>
Signed-off-by: Felix Kästner <felix.kaestner@sap.com>
Merging this branch changes the coverage (3 decrease, 1 increase)
Coverage by fileChanged files (no unit tests)
Please note that the "Total", "Covered", and "Missed" counts above refer to code statements instead of lines of code. The value in brackets refers to the test coverage of that file in the old version of the code. Changed unit test files
|
hardikdr
added
the
area/switch-automation
IvoGoman
reviewed
Aug 31, 2026
Comment on lines
+313
to
+319
| case totalAdjacencies == 0: | ||
| conditions.Set(fabric, metav1.Condition{ | ||
| Type: evpnv1alpha1.UnderlayConvergedCondition, | ||
| Status: metav1.ConditionFalse, | ||
| Reason: evpnv1alpha1.NoResourcesReason, | ||
| Message: "No underlay adjacencies expected", | ||
| }) |
Contributor
There was a problem hiding this comment.
The condition message seems off to me. Should it be No underlay adjacencies created yet to signal the reconciliation is not yet done, analogous to the overlay?
Otherwise, if no underlay adjacencies is a valid outcome. I would expect a case for fullAdjacencies == 0 && totalAdjacencies > 0 and one for fullAdjacencies == 0 && totalAdjacencies == 0.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Details in each commit..