[codex] Stabilize explorer map layout#202
Draft
rdhyee wants to merge 3 commits into
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #199.
This stabilizes the explorer globe layout so the Cesium container is anchored to viewport height instead of deriving its height from grid-column width. It also reserves bounded space for search status text and the view toolbar so loading/search/table controls cannot move the map frame.
Changes
#cesiumContaineraspect-ratio sizing with--explorer-map-height: clamp(500px, 65vh, 680px).clamp(360px, 58vh, 520px)..side-panelmax height to the same map-height variable.scrollbar-gutter: stableandminmax(0, 1fr)for layout-width stability..explorer-controls, reserved a two-line#searchResultslive region, and reserved view-toolbar height so table controls do not shift the table/globe anchor.Validation
quarto render explorer.qmdnode --check tests/playwright/explorer-layout-stability.spec.jsenv NODE_PATH=/Users/raymondyee/C/src/iSamples/isamplesorg.github.io/node_modules /Users/raymondyee/C/src/iSamples/isamplesorg.github.io/node_modules/.bin/playwright test tests/playwright/explorer-layout-stability.spec.js --project=chromium --reporter=lineThe focused Playwright spec passed: 2 tests passed on Chromium.