Skip to content

Prevent reverse-proxy SSRF via @ in sub-path of authority-only target #916

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
Copilot wants to merge 2 commits into
base: master
Choose a base branch
from
Draft

Prevent reverse-proxy SSRF via @ in sub-path of authority-only target #916

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
2cf30b2
Initial plan
Copilot Oct 28, 2026
59c7111
Apply remaining changes
Copilot Oct 28, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 10 additions & 1 deletion http/server/HttpService.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -196,7 +196,16 @@ std::string HttpService::GetProxyUrl(const char* path) {
std::string url;
for (auto iter = proxies.begin(); iter != proxies.end(); ++iter) {
if (hv_strstartswith(path, iter->first.c_str())) {
url = iter->second + (path + iter->first.length());
const char* rest = path + iter->first.length();
url = iter->second;
// authority-only target: make sure the sub path can't alter host (e.g. "@host")
size_t authority = url.find("://");
authority = authority == std::string::npos ? 0 : authority + 3;
Comment on lines +202 to +203
bool has_path = url.find('/', authority) != std::string::npos;
if (!has_path && *rest != '\0' && *rest != '/') {
url += '/';
}
url += rest;
break;
}
}
Expand Down
Loading