Repository navigation
Conversation
rimi-itk
force-pushed
the
2.x
branch
5 times, most recently
from
October 27, 2026 08:42
d4e3e6a to
5d6f978
Compare
rimi-itk
marked this pull request as ready for review
October 28, 2026 09:36
jekuaitk
approved these changes
Oct 30, 2026
| } | ||
|
|
||
| return $string; | ||
| return (string) $string; |
Contributor
There was a problem hiding this comment.
Seems strange that this is necessary, but im guessing its due to \Drupal\Component\Gettext\PoItem::__toString not guaranteed to being a string?
Collaborator
Author
There was a problem hiding this comment.
Cast removed in 4f77723. It may have been introduced by a previous Rector run, but it's not needed – and maybe Rector has become better at analysing the code.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.