Repository navigation
Release 1.4.0 - #79
Open
turegjorup wants to merge 46 commits into
Open
turegjorup wants to merge 46 commits into
turegjorup wants to merge 46 commits into
Conversation
Restore the APP_PATH_PREFIX rewrite in nginx and the php-cs-fixer exclusions. Remove the JavaScript and styles workflows, because the project has no assets. Give the cron-metrics router the lowest priority on the server, because the importer uses the same domain.
Rector changes are syntax only: new without parentheses and #[\Override] on overridden properties.
Keep the APP_PATH_PREFIX rewrite in .docker/templates/server.d/, the same as event-database-imports, so template updates do not remove it. The include line matches itk-dev/devops_itkdev-docker#163.
Keep require.php at >=8.3, so that Rector does not apply the PHP 8.5 rules in this PR.
Rector changes are syntax only: new without parentheses and #[\Override] on overridden properties.
…pdate chore: update docker compose template and PHP 8.5
chore: require PHP 8.5 and apply Rector PHP 8.5 rules
Elasticsearch 8.19.23 is the same version as in event-database-imports. The API does not use RabbitMQ (no messenger or amqp).
Add pb30/phpstan-composer-analysis to report packages used directly but only installed transitively, and add the 10 missing requirements at their installed versions. composer.lock adds only the analysis packages.
chore: update Elasticsearch image and remove unused RabbitMQ
chore: require all directly used packages
Symfony 7.4.23 fixes 18 security advisories. Run with COMPOSER_POLICY_COOLDOWN_PERIOD='4 days', because 7.4.23 is still in the 7-day cooldown and all older 7.4 versions have advisories. Rector and PHPStan stay at their versions; they are updated in a separate PR.
chore: update dependencies in-constraint
Rector 2.8 adds ParamAndEnvAttributeRector and DirnameDirConcatStringToDirectStringPathRector. Both changes are equivalent code. The PHPStan baseline does not change.
chore: update Rector and PHPStan and apply new Rector rules
API Platform 4.4 exports OpenAPI 3.2.0 and no longer adds charset to the application/ld+json content type (api-platform/core#8226). Update the content-type assertions in the tests. Vocabulary.tags has no element type, so the spec now has no item type for it.
API Platform 4.4 does not guess an item type for untyped arrays, so the spec had 'items: {}' and oasdiff reported a breaking change. The tags are keyword strings in Elasticsearch.
chore: update API Platform to 4.4
Keep the ITK Dev .php-cs-fixer.dist.php. It already excludes config/reference.php, which is the only change in the recipe.
debug:router output is unchanged.
Keep the project api_user_provider.
Do not add the FrankenPHP hot-reload block to templates/base.html.twig. The project uses php-fpm.
PHPStan strict rules do not allow the short ternary from the framework-bundle recipe.
Use the same pattern as APP_PROJECT_URI.
chore: update Symfony Flex recipes
Add phpstan/phpstan-deprecation-rules. Put the 20 #[ApiFilter] deprecations (API Platform 4.4) in the baseline, because the change to #[QueryParameter] needs application code changes. CI now finds new deprecations.
Use an ignoreErrors rule in phpstan.dist.neon instead of baseline entries, so the reason is documented.
chore: add PHPStan deprecation rules
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #79 +/- ##
=======================================
Coverage ? 74.39%
Complexity ? 264
=======================================
Files ? 30
Lines ? 738
Branches ? 0
=======================================
Hits ? 549
Misses ? 189
Partials ? 0
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Release 1.4.0: the quarterly update (PR-70 to PR-78).
Changes
[Unreleased]entries to## [1.4.0] - 2026-11-08, and open a new[Unreleased]section.[Unreleased]→1.4.0...HEAD, add[1.4.0]from1.3.0).The release contains:
composer.json(chore: require all directly used packages #73).Why
This is the quarterly update (cybersikkerhedsaftale).
mainhas no commits that are missing indevelop, so the release branch needs no merge.Changes that consumers can see
application/ld+jsonwithout; charset=utf-8(API Platform 4.4, chore: update API Platform to 4.4 #76).Vocabulary.tags: the spec hasitems: type: stringinstead ofstring, null.After the deploy
itkdev/php8.5-fpm:alpine,nginx/nginx-unprivileged:alpine)./api/v2/load, for example/api/v2/docs. TheAPP_PATH_PREFIXrewrite is now in.docker/templates/server.d/app-path-prefix.conf.template(chore: update docker compose template and PHP 8.5 #70).https://<domain>/cron-metricsshows the statistics fromevent-database-imports. This app's metrics router has priority 1 (chore: update docker compose template and PHP 8.5 #70).APP_PROJECT_URIis correct in the server.env.local. The newDEFAULT_URIusesCOMPOSE_DOMAINin the same way (chore: update Symfony Flex recipes #77).Remaining work (not in this release)
#[ApiFilter]→#[QueryParameter]: API Platform 4.4 deprecates#[ApiFilter], and API Platform 6.0 removes it. The change needs application code changes in the 7 DTOs and inAbstractProvider::getFilters(). A commented ignore rule inphpstan.dist.neondocuments it (chore: add PHPStan deprecation rules #78).[error]and[critical]log lines for 401, 404 and 406 responses to stderr. This is not new.server.dinclude line comes from feat: include project nginx config from server.d in templates devops_itkdev-docker#163, which is still open. Until it is merged, a newtemplate:updateremoves the include line.