Repository navigation
Archiving cleanup - #11
Merged
Merged
Conversation
rimi-itk
force-pushed
the
feature/archiving-cleanup
branch
from
October 30, 2026 15:04
eec6a6a to
e7ebea1
Compare
rimi-itk
force-pushed
the
feature/archiving-cleanup
branch
from
October 30, 2026 21:35
b0fa3ec to
90d86b3
Compare
rimi-itk
force-pushed
the
feature/archiving-cleanup
branch
from
November 2, 2026 10:37
befddb8 to
52b9ebe
Compare
rimi-itk
force-pushed
the
feature/archiving-cleanup
branch
from
November 2, 2026 10:38
52b9ebe to
06ed837
Compare
rimi-itk
marked this pull request as ready for review
November 2, 2026 10:38
jekuaitk
reviewed
Nov 2, 2026
jekuaitk
left a comment
jekuaitk
left a comment
Contributor
There was a problem hiding this comment.
Looks good. But as mentioned i think we should remove the configuration to run the handler on delete, cf. https://github.com/itk-dev/os2forms_f2/blob/feature/archiving-cleanup/src/Plugin/WebformHandler/WebformHandlerAdditionalStatesTrait.php#L90, due to the handler (and our handlers in general) not implementing postDelete but only postSave, cf. https://github.com/itk-dev/os2forms_f2/blob/feature/archiving-cleanup/src/Plugin/WebformHandler/WebformHandlerF2.php#L39
jekuaitk
approved these changes
Nov 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.