Repository navigation
Release 0.0.15 - #13
Merged
Merged
Conversation
Release 0.0.14
no message
execFileSync throws on a non-zero exit, but the catch block printed the error and returned, so the process exited 0 even when docker compose (and the command it ran) failed. Callers such as Ansible and Woodpecker then saw a successful run. Exit with the underlying command's status code, and exit non-zero when the env file is missing. This is the only command-execution path; it is a passthrough for all docker compose subcommands (run, exec, up, pull, ...), so the fix covers every command the wrapper runs.
The Taskfile still selected compose files via DOCKER_COMPOSE_FILES_OSX, which referenced docker-compose.mac-nfs.yml - a file already removed from develop - so dev:cli was broken on macOS. Drop the dead file-selection vars and call 'docker compose run' directly. Also: rename buildTest -> build:macos, make dev:build cache via sources/generates, switch task summaries to desc, ignore .task, and document the dev workflow in the README. Completes the docker-compose -> docker compose migration started in #4 (docker-compose.yml and docker-compose.mac-nfs.yml already landed on develop).
Clean up Taskfile and dev tooling for docker compose
fix: propagate command exit code instead of swallowing failures
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Release 0.0.15.
Changes
docker compose.Plus the release commit (CHANGELOG
0.0.15section +package.jsonbump).Release process
Merging this into
mainand pushing the0.0.15tag triggersbuild_release.yml, which rebuilds the binary and publishes the GitHub release.mainis then back-merged intodevelop.