Skip to content

ld: better video object finder in ld source #719

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
iparamonau merged 3 commits into from
Oct 9, 2026
Merged

ld: better video object finder in ld source #719

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
cf1f1d8
ld: better video object finder in ld source
iparamonau Oct 8, 2026
8b98803
Merge branch 'dev' into fix/ld-type-list
iparamonau Oct 8, 2026
1f352a4
Merge branch 'dev' into fix/ld-type-list
iparamonau Oct 9, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
28 changes: 17 additions & 11 deletions lib/utils.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -632,17 +632,23 @@ export function findMainLdObjectWithVideo(ld) {

let json = ld.videoobject || ld.mediaobject;

/*
|| (ld.newsarticle && (ld.newsarticle.video || ld.newsarticle.videoobject))
|| (ld.tvepisode && (ld.tvepisode.video || ld.tvepisode.videoobject))
|| (ld.movie && (ld.movie.video || ld.movie.videoobject))
|| (ld.tvclip && (ld.tvclip.video || ld.tvclip.videoobject));
*/
if (!json) { // try to find video attached to main object
var mainObjWithVideo = ld && Object.values(ld).find((obj) => obj.video || obj.videoObject);
if (mainObjWithVideo) {
json = mainObjWithVideo.video || mainObjWithVideo.videoObject;
}
if (!json) {
// Let's find videos in objects with "@type" arrays: ["CreativeWork", "VideoObject"]
// or other embeddable entities
// or entiites attached to main object
json = Object.values(ld).find((obj) => {
const type = obj['@type'];
return Array.isArray(type)
&& (type.indexOf('VideoObject') > -1 || type.indexOf('videoobject') > -1)
|| obj.embedUrl
|| obj.video || obj.videoObject;
});
}

// ex.: https://nypost.com/2025/12/16/us-news/obamas-planned-to-meet-with-rob-reiner-and-wife-the-night-couple-was-killed/
// https://nypost.com/video/artist-jailed-for-letting-people-touch-her-privates-in-public/
if (json && (json.video || json.videoObject)) {
json = json.video || json.videoObject;
}

if (json && Array.isArray(json) && json.length === 1) {
Expand Down
Loading