support additional class loaders for savables#2888
Conversation
There was a problem hiding this comment.
Code Review
This pull request introduces support for loading Savable classes using additional class loaders provided by the AssetManager during binary import. This is achieved by overloading SavableClassUtil.fromName to accept a collection of class loaders and attempting to load classes through them if the default lookup fails. Feedback focuses on thread safety and performance optimizations: specifically, synchronizing the iteration over additionalClassLoaders to prevent ConcurrentModificationException and caching the class loaders in BinaryImporter to avoid redundant list allocations and GC pressure during object loading.
Important
The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.
Reimplement deprecated apis needed to fix jMonkeyEngine/sdk#659