Repository navigation
Add Transform instances to TempVars - #3020
Merged
Merged
Conversation
Added new Transform instances to TempVars for additional transformations.
jaime-jmebot
suggested changes
Oct 24, 2026
jaime-jmebot
left a comment
jaime-jmebot
left a comment
Contributor
There was a problem hiding this comment.
Thanks for adding these temporary Transform instances!
Before this can be merged, there are a couple of small items to address:
- Add
import com.jme3.math.Transform;to fix the compilation error. - Add a Javadoc comment above
tr1andtr2to stay consistent with the existing field definitions inTempVars.
Co-authored-by: Jaime Bot <jaime@rblb.it>
jaime-jmebot
approved these changes
Oct 24, 2026
jaime-jmebot
left a comment
jaime-jmebot
left a comment
Contributor
There was a problem hiding this comment.
Looks great now! Thanks for updating the imports and Javadocs. 🚀
Member
|
Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added new Transform instances to TempVars for additional transformations.