Skip to content

ci: align npm publish workflow with npm OIDC docs#15

Merged
baransu merged 1 commit into
masterfrom
baransu/rimless-publish-404
May 25, 2026
Merged

ci: align npm publish workflow with npm OIDC docs#15
baransu merged 1 commit into
masterfrom
baransu/rimless-publish-404

Conversation

@baransu
Copy link
Copy Markdown

@baransu baransu commented May 25, 2026

Summary

  • Bump `actions/checkout` and `actions/setup-node` to `@v6` to match the npm Trusted Publishing docs example.
  • Bump `node-version` from 22 to 24 so the runner ships npm >= 11.5.1, which is required for npm's OIDC publish exchange. Under Node 22 the publish was falling back to anonymous and the registry returned a misleading `404 Not Found` for `@jam.dev/rimless`.

Test plan

  • Cut a patch release and confirm `npm publish` succeeds via OIDC (no `NPM_TOKEN` secret used).

Bumps actions/checkout and actions/setup-node to v6 and node-version
to 24 to match npm's Trusted Publishing example. Node 24 ships npm
>= 11.5.1, which is required for the OIDC token exchange — Node 22
was shipping npm 10.x so the publish was falling back to anonymous
and returning a misleading 404 from the registry.
Copy link
Copy Markdown

@devin-ai-integration devin-ai-integration Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Devin Review found 1 potential issue.

View 1 additional finding in Devin Review.

Open in Devin Review

uses: actions/setup-node@v6
with:
node-version: "22"
node-version: "24"
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚩 Volta-pinned Node version diverges significantly from CI

The package.json:60-62 pins Node to 18.19.0 via Volta, while this workflow now uses Node 24. This was already a mismatch before the PR (Node 22 vs Volta 18), but the gap is widening. If any dependency or build step relies on Volta's pinned version semantics, the CI publish environment may behave differently from local development. This is a pre-existing inconsistency but worth being aware of.

Open in Devin Review

Was this helpful? React with 👍 or 👎 to provide feedback.

@baransu baransu merged commit 43feeb0 into master May 25, 2026
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant