Skip to content

fix: Address Devin review on the new Jam skills - #23

Merged
baransu merged 2 commits into
masterfrom
tomasz/devin-review-fixes
Oct 26, 2026
Merged

baransu merged 2 commits into
masterfrom
tomasz/devin-review-fixes

Conversation

@baransu

@baransu baransu commented Oct 26, 2026 •

Copy link
Copy Markdown
Contributor

Why

Devin's review of #22 found four places where a skill assumed every Jam is a narrated video, or that one ticket covers a whole Jam. #22 merged before they were addressed.

What changed

  • jam: for a bare link to a video with the mic on, the router reads the transcript before routing. The spoken asks are there, and a title like "Feedback" says nothing about them. If the captions are not ready, it retries once, then routes on the details and says so. (comment)
  • jam-to-ticket: an existing ticket covers only the problems it describes. A Jam that raises several problems gets tickets for the rest. "Was this Jam ever ticketed?" stays read-only. (comment)
  • jam-proof-table: checks each Jam by its type. A video is checked by its frames and a screenshot by its screenshot. A replay is checked by its events, console and network, and is marked unconfirmed when those cannot settle the claim. (comment)
  • jam-to-tasks: a Jam with no narration skips the transcript step and takes its asks from the title, description and comments, and the coverage check reads those. A screenshot Jam uses its screenshot in place of frames. (comment)

Devin's second pass on this PR:

  • jam-proof-table no longer rejects a screenshot as "a single frozen frame". That test is for video.
  • The router sends a silent Jam whose description or comments ask for several changes to jam-to-tasks.
  • A task from a silent Jam cites its field (title, description, a comment) in place of a timestamp.
  • One Unreleased CHANGELOG line covers the batch.

Review guide

  1. LOGIC skills/jam/SKILL.md: the transcript read in "A Jam link with no clear ask"
  2. LOGIC skills/jam-to-ticket/SKILL.md: step 2, matches per problem
  3. LOGIC skills/jam-proof-table/SKILL.md: step 4, the type branch
  4. LOGIC skills/jam-to-tasks/SKILL.md: steps 2, 3, 4 and 7 for silent and screenshot Jams
  5. MECHANICAL CHANGELOG.md

Verification

Use case Configuration Proof
A bare link to a narrated feedback Jam reads the transcript, then routes to jam-to-tasks Claude Code, claude-opus-5-5, only this plugin's skills, writes blocked 2/2
A bare bug link, and "take a look at this jam", read the transcript, then route to jam-fix same 4/4
Repo checks node scripts/check.mjs, npm test pass, 34/34

Not verified:

  • The jam-to-ticket, jam-proof-table and jam-to-tasks changes have no runs. They are text changes that follow the type rules already in jam-fix.
  • Devin's fifth comment, no end-to-end upload run, is still open: none of the new skills has produced a Jam in a real run yet.

Rollback

Revert this PR. Nothing outside skills/ changes.

… duplicate check, proof by Jam type, silent Jams in jam-to-tasks
devin-ai-integration[bot]

This comment was marked as resolved.

…-ask Jam to jam-to-tasks, tasks cite a field when there is no timestamp, changelog line
@baransu
baransu merged commit 7f260f1 into master Oct 26, 2026
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant