Repository navigation
fix: Address Devin review on the new Jam skills - #23
Merged
Merged
Conversation
… duplicate check, proof by Jam type, silent Jams in jam-to-tasks
…-ask Jam to jam-to-tasks, tasks cite a field when there is no timestamp, changelog line
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
Devin's review of #22 found four places where a skill assumed every Jam is a narrated video, or that one ticket covers a whole Jam. #22 merged before they were addressed.
What changed
jam: for a bare link to a video with the mic on, the router reads the transcript before routing. The spoken asks are there, and a title like "Feedback" says nothing about them. If the captions are not ready, it retries once, then routes on the details and says so. (comment)jam-to-ticket: an existing ticket covers only the problems it describes. A Jam that raises several problems gets tickets for the rest. "Was this Jam ever ticketed?" stays read-only. (comment)jam-proof-table: checks each Jam by its type. A video is checked by its frames and a screenshot by its screenshot. A replay is checked by its events, console and network, and is marked unconfirmed when those cannot settle the claim. (comment)jam-to-tasks: a Jam with no narration skips the transcript step and takes its asks from the title, description and comments, and the coverage check reads those. A screenshot Jam uses its screenshot in place of frames. (comment)Devin's second pass on this PR:
jam-proof-tableno longer rejects a screenshot as "a single frozen frame". That test is for video.jam-to-tasks.Review guide
LOGICskills/jam/SKILL.md: the transcript read in "A Jam link with no clear ask"LOGICskills/jam-to-ticket/SKILL.md: step 2, matches per problemLOGICskills/jam-proof-table/SKILL.md: step 4, the type branchLOGICskills/jam-to-tasks/SKILL.md: steps 2, 3, 4 and 7 for silent and screenshot JamsMECHANICALCHANGELOG.mdVerification
jam-to-tasksclaude-opus-5-5, only this plugin's skills, writes blockedjam-fixnode scripts/check.mjs,npm testNot verified:
jam-to-ticket,jam-proof-tableandjam-to-taskschanges have no runs. They are text changes that follow the type rules already injam-fix.Rollback
Revert this PR. Nothing outside
skills/changes.