Add setting of sin_len/sin6_len for BSD and macOS#3765
Open
softins wants to merge 1 commit into
Open
Conversation
Member
|
Unfotunately, it still hangs. It seems to take some more time before it hangs. But this might also be to less people being active on the servers at this time. I still think this is a good bug fix. |
Member
|
I'm inclined to approve it as is - even though it doesn't fix the bug. |
Collaborator
|
Needs a better change log message -- it looks like it's initialising the BSD IP protocol packet (??) length in the header (not present on other *nix flavours). If that was missing, I'm surprised it wasn't core dumping like mad - unless it really works like other *nix flavours underneath. But yes, looks like a good fix to have, if it means the header is thus compliant. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Short description of changes
This is a test to see if it fixes the problem reported in #3758
CHANGELOG: Client/Server: Fix a potential problem with sockets on BSD/macOS
Context: Fixes an issue?
Hoping it might fix #3758, but don't know for sure
Does this change need documentation? What needs to be documented and how?
No
Status of this Pull Request
Ready to test. It compiles, but don't know if it fixes the issue.
What is missing until this pull request can be merged?
Testing
Checklist