Added premake support for better Visual Studio and other build systems (like Makefile) support.#1456
Added premake support for better Visual Studio and other build systems (like Makefile) support.#1456AashiqMeow12 wants to merge 7 commits into
Conversation
As otherwise, cannot link this library with other dependencies of Hazel engine.
So that buidling Hazel (which includes this repo as a submodule) does not make git think the submodule has changes to commit. Note tha the Hazel build system should really be using "out-of-source" builds instead.
Maybe it isn't needed, we will update this in the future, for now it is okay.
There was a problem hiding this comment.
@AashiqMeow12 thank you for your PR.
Could you change everything to two-spaces indentation instead of tabs. This makes it inline with all the other files in this project.
@jbeder : Do we want or are willing to accept more build systems?
| kind "StaticLib" | ||
| systemversion "latest" | ||
| language "C++" | ||
| cppdialect "C++17" |
There was a problem hiding this comment.
C++11 should be enough as a requirement.
| bin | ||
| bin-int | ||
| yaml-cpp.vcxproj | ||
| yaml-cpp.vcxproj.filters No newline at end of file |
There was a problem hiding this comment.
Please do not change the .gitignore list. I do not think these changes are necessary.
|
|
||
| filter "configurations:Dist" | ||
| runtime "Release" | ||
| optimize "on" No newline at end of file |
There was a problem hiding this comment.
I believe there is a new line missing at the end of the file.
| { | ||
| "src/**.h", | ||
| "src/**.cpp", | ||
|
|
There was a problem hiding this comment.
There are two tabs not are not needed.
|
I'm pretty sure CMake generates these. If so, we should just defer to CMake. I made the exception for bazel because it really is fundamentally different and I actually like its fundamental difference. |
3 participants
No description provided.