feat: add thread-safe contains() function for Node.#1457
Open
sxrzh wants to merge 2 commits into
Open
Conversation
Contributor
Author
|
Note that for a sequence node and an integer within [0, size - 1] as the key, |
SGSSGene
requested changes
Jul 7, 2026
Comment on lines
+398
to
+401
| inline bool Node::contains(const Key& key) const { | ||
| EnsureNodeExists(); | ||
| return ((const detail::node*)m_pNode)->get(key, m_pMemory) != nullptr; | ||
| } |
Collaborator
There was a problem hiding this comment.
This is not thread safe. The problem is that the function EnusreNodeExists is not thread-safe. Even though it is marked as 'const' is manipulates the member variable m_pMemory which is marked as mutable.
I think instead of calling EnsureNodeExists it should do the check it self and return false if the node doesn't exists.
sxrzh
force-pushed
the
fix1350&1092-contains
branch
from
470d5e9 to
4249380
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add
contains()function to check ifnode[key]exists.Close #1350 and close #1092.