Skip to content

Fix for not calling restore during build for certain overload #364

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jeffkl merged 1 commit into from
Jul 7, 2026
+48 −2
Merged

Fix for not calling restore during build for certain overload #364

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
46 changes: 46 additions & 0 deletions src/Microsoft.Build.Utilities.ProjectCreation.UnitTests/BuildTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -276,6 +276,52 @@ public void CanRestoreAndBuildMultipleTimes()
result.ShouldBeTrue(buildOutput.GetConsoleLog());
}

[Fact]
public void TryBuildWithRestoreAndTargetWithoutBuildOutputRestoresBeforeBuild()
{
string markerPath = Path.Combine(TestRootPath, $"{Guid.NewGuid():N}.restore-marker");

ProjectCreator.Create(path: GetTempFileName(".proj"))
.Target("Restore")
.Task(
"WriteLinesToFile",
parameters: new Dictionary<string, string?>
{
["File"] = markerPath,
["Lines"] = "restored",
["Overwrite"] = bool.TrueString,
})
.Target("Build")
.TaskError("Restore target did not run.", condition: $"!Exists('{markerPath}')")
.Save()
.TryBuild(restore: true, target: "Build", globalProperties: null, out bool result);

result.ShouldBeTrue();
}

[Fact]
public void TryBuildWithRestoreWithoutBuildOutputRestoresBeforeBuild()
{
string markerPath = Path.Combine(TestRootPath, $"{Guid.NewGuid():N}.restore-marker");

ProjectCreator.Create(path: GetTempFileName(".proj"), defaultTargets: "Build")
.Target("Restore")
.Task(
"WriteLinesToFile",
parameters: new Dictionary<string, string?>
{
["File"] = markerPath,
["Lines"] = "restored",
["Overwrite"] = bool.TrueString,
})
.Target("Build")
.TaskError("Restore target did not run.", condition: $"!Exists('{markerPath}')")
.Save()
.TryBuild(restore: true, globalProperties: null, out bool result);

result.ShouldBeTrue();
}

[Fact]
public void ProjectCollectionLoggersWork()
{
Expand Down
4 changes: 2 additions & 2 deletions src/Microsoft.Build.Utilities.ProjectCreation/ProjectCreator.Build.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -59,7 +59,7 @@ public ProjectCreator TryBuild(bool restore, string target, IDictionary<string,
{
BuildOutput buildOutput = BuildOutput.Create();

result = Build(restore: false, [target], globalProperties, buildOutput, out _);
result = Build(restore, [target], globalProperties, buildOutput, out _);

return this;
}
Expand Down Expand Up @@ -163,7 +163,7 @@ public ProjectCreator TryBuild(bool restore, IDictionary<string, string>? global
{
BuildOutput buildOutput = BuildOutput.Create();

result = Build(restore: false, targets: null, globalProperties, buildOutput, out _);
result = Build(restore, targets: null, globalProperties, buildOutput, out _);

return this;
}
Expand Down
Loading