RTECO-2020 - Improve agent plugins tests - #3686
Merged
Merged
Conversation
udaykb2
force-pushed
the
RTECO-2020-improve-agent-plugins-tests
branch
from
August 27, 2026 17:30
781dd33 to
d4370c3
Compare
udaykb2
marked this pull request as ready for review
August 28, 2026 05:01
udaykb2
force-pushed
the
RTECO-2020-improve-agent-plugins-tests
branch
from
August 28, 2026 06:09
c321535 to
1879f6d
Compare
…ling Add assertPluginsInstalledNatively() to verify plugins via harness native CLI (claude/codex plugin list --json, cursor/vscode manifest files) Add verifyIsolatedHome() to verify HOME env var isolation works correctly Add 30-second timeout to CLI commands to prevent test hangs Parameterize VSCode repo path instead of hard-coding for test flexibility Include stderr context in JSON parse error messages for better debugging Improve type assertion error messages to show actual types received Fix platform-specific temp path check to work cross-platform (Linux/macOS/Windows) Add input parameter validation to catch test misconfiguration early Add context import for timeout support Update 16 fixture definitions to include all 4 harnesses (claude/codex/cursor/vscode) Extract allAgentHarnesses constant for repeated harness slice Skip Cursor/VSCode in native checks (they have no native CLI commands) Remove redundant assertCursorPluginInstalled() and assertVSCodePluginInstalled() functions Fix gosec G703 path traversal warnings with proper #nosec directives This improves test reliability, debuggability, and cross-platform compatibility.
udaykb2
force-pushed
the
RTECO-2020-improve-agent-plugins-tests
branch
from
August 28, 2026 06:11
1879f6d to
7cdc484
Compare
…ling Add assertPluginsInstalledNatively() to verify plugins via harness native CLI (claude/codex plugin list --json, cursor/vscode manifest files) Add verifyIsolatedHome() to verify HOME env var isolation works correctly Add 30-second timeout to CLI commands to prevent test hangs Parameterize VSCode repo path instead of hard-coding for test flexibility Include stderr context in JSON parse error messages for better debugging Improve type assertion error messages to show actual types received Fix platform-specific temp path check to work cross-platform (Linux/macOS/Windows) Add input parameter validation to catch test misconfiguration early Add context import for timeout support Update 16 fixture definitions to include all 4 harnesses (claude/codex/cursor/vscode) Extract allAgentHarnesses constant for repeated harness slice Skip Cursor/VSCode in native checks (they have no native CLI commands) Remove redundant assertCursorPluginInstalled() and assertVSCodePluginInstalled() functions Fix gosec G703 path traversal warnings with proper #nosec directives This improves test reliability, debuggability, and cross-platform compatibility.
…ub.com/jfrog/jfrog-cli into RTECO-2020-improve-agent-plugins-tests
…ub.com/jfrog/jfrog-cli into RTECO-2020-improve-agent-plugins-tests
fluxxBot
approved these changes
Aug 31, 2026
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
agent_plugins_test: add native harness verification with improved error handling
This improves test reliability, debuggability, and cross-platform compatibility.
masterbranch.go vet ./....go fmt ./....