refactor: remove dead code left by recent cuts - #1083
Merged
Merged
Conversation
- Delete packages/ui/src/*.generated.ts: orphaned since the ui extension was deleted (#895) and accidentally re-added by #922; nothing imports it. - package-files.ts: drop the `limits` parameters of hashPackageFiles and compareFiles (only the tarball reader removed in #1048 shared them) and unexport packageFileLimits, hashPackageFiles and compareFiles. - Unexport 29 values used only inside their own non-public module. - Fix stale comments naming the removed benchmark command and core's removed tarball reader. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This sweeps dead code left by #1048, #1050, #1055, #1049 and #1066. Net: 38 insertions, 43 deletions (-5 lines). It also deletes about 71 KB of orphaned generated CSS that sat on two lines.
The search found very little dead code: the earlier cuts removed their own helpers.
npx knip(not added as a dependency) plus agit grepreference count over every export inpackages/*/src,scripts/,test/andpackages/*/testfound only one symbol with no references at all,extensionHooksSchema. It is public API: it is documented in docs/EXTENSIONS.md and belongs to the hooks contractpackages/mcpuses, so it stays.Removals
packages/ui/src/kit-styles.generated.tsandstyles.generated.ts(the whole remainingpackages/ui/)git grep -e kit-styles -e styles.generated -e packages/uifinds nothing. The ui extension was deleted in c5293fd (#895), and 1c70733 (#922) re-added these two generated files by accident. The directory has no package.json, so it was never a workspace.package-files.ts: drop thelimits = packageFileLimitsparameter fromhashPackageFilesandcompareFiles; unexportpackageFileLimits,hashPackageFilesandcompareFilesgit grep -e 'hashPackageFiles(' -e 'compareFiles('finds only the two definitions and two internal calls, none passinglimits. The parameter was shared withreadTarball/verifyPackageOnline, which #1048 removed. No importer ofpackage-files.tsimports these three names.package.json#exportsentry, and neither the entries nor tests re-export them):auth.ts: authSeedSchema, openAuthDatabase, hermeticRateLimitFactor.addon-install.ts: sitePaths, artifactManifestKeys, artifactLockProblem, addonLoadError, isPackageSpec, independentLockProblem, localTarballProblem.addon-manifest.ts: artifactMediaTypes, MAX_ARTIFACT_DOCUMENTS, isContractVersion, isExtensionTargets, declaredPrincipalSecurity.cli-errors.ts: contextPlaceholders.extensions-cli.ts: addonCommands.openapi-check.ts: officialOpenApiSchema, openApiSchemaObjects.project-schemas.ts: projectSchemaName, projectSchemaFileLimits.project-tests.ts: readSeed.temp-dirs.ts: staleRunDirectoryMs. storecollection.ts: READER_LIMITS, refuseBalance, invalidRecord, inState, refuseLocked, STORED_OUTSIDE. storestore.ts: storeSeedSchemapackages/{auth,store}/src/extension.ts. Removed the line intest/fixtures/addons/tarball.mjssaying the fixture is "Independent of core's own reader (package-files.ts)"benchmarkwas removed in #1048, and so was core's tarball reader (readTarball).Checked and kept
picomatchis used byscripts/ci-changes.ts,@hey-api/openapi-tsbytest/openapi.test.ts, andsemverby the release scripts.filesentries: all exist.scripts/operational-drills.tsruns in ci.yml,render-homebrew.tsin release-pack,scripts/repro/*in v8-jit-repro.yml, anddata/agents/index.d.tsdeclaresindex.js.commandOptions: every flag is still read in cli.ts or extensions-cli.ts.packages/auditor@jimhoyd/urlcode-audit(release-bump, package-audit and scaffold tests) use them as synthetic sibling-package names to test generic logic, so they were not changed.Filed instead of done
DROP TABLE IF EXISTS auth_servers. This is upgrade code for database shapes from before One serving process per database: replace the host lease with an OS lock #1050 and feat(store): audit log in the store with a core tap; name is the role; cut ownerless (#1052 S4, #1041) #1066. Removing it changes what an existing database does when it opens, so the owner needs to decide.Verification
npm run typecheck: passes.npm run verify: exit 0. It covers lint, typecheck, tooling typecheck, check:code, check:docs, build, the root suite (1319 tests) and every workspace's verify plus the add-on, proof and ecosystem suites, all with 0 failures.test:packagewas not run.🤖 Generated with Claude Code