fix(test): make ecosystem imports and shutdown checks portable - #1129
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem and change
Run 36886904873 fails Windows Node 24 packed ecosystem integration with
ERR_UNSUPPORTED_ESM_URL_SCHEME:import()receives a bare Windows drive path. Convert the installed module path withpathToFileURLbefore importing it.The test also assumed SIGTERM invokes Node handlers on Windows. Add a separate explicit
close()check on every platform, requiring natural process exit and port release. Keep the signal-handler assertion on Unix and explain the Windows limitation in the fixture README. All application, sandbox and host-admission assertions remain intact.Fixes #1128.
Verification
npm run test:ecosystem: all 13 tests passed locally.npm run verify: passed, including 1,397 root tests, workspace verification and application proofs.test/prepare.test.tsnpm-pack subprocess timed out after emitting archive JSON; tracked in [Bug]: Windows npm pack fixture times out after emitting archive JSON #1130, cause unverified. The full matrix is therefore not green.Compatibility and security
Integration-test and evidence-documentation changes only. No runtime, public API, policy or sandbox changes. Windows process termination is not presented as graceful runtime cleanup.