Repository navigation
Fix Emacs-Mule codeToMbcLength, used by stateless-ISO-2022-JP too - #71
Merged
Merged
Conversation
The code is an unsigned 32-bit value held in a Java int. 0xffffffff is -1 as an int, so `code > 0xffffffff` was true for every non-negative code, and every non-ASCII code got length 0. Test the high bit of each byte instead, as CRuby's code_to_mbclen in enc/emacs_mule.c does with unsigned compares. This also fixes the stateless-ISO-2022-JP encodings, which share this implementation. JRuby looped forever in String#tr and #codepoints on them, and Integer#chr rejected valid codes.
headius
approved these changes
Nov 11, 2026
headius
left a comment
headius
left a comment
Member
There was a problem hiding this comment.
Yup, silly mistake somewhere along the way.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The code is an unsigned 32-bit value held in a Java int. 0xffffffff is -1 as an int, so
code > 0xffffffffwas true for every non-negative code, and every non-ASCII code got length 0. Test the high bit of each byte instead, as CRuby's code_to_mbclen in enc/emacs_mule.c does with unsigned compares.This also fixes the stateless-ISO-2022-JP encodings, which share this implementation. JRuby looped forever in String#tr and #codepoints on them, and Integer#chr rejected valid codes.