Skip to content

Omit the stacktrace for JOniException - #89

Open
eregon wants to merge 1 commit into
jruby:masterfrom
eregon:omit-stacktrace-for-performance
Open

eregon wants to merge 1 commit into
jruby:masterfrom
eregon:omit-stacktrace-for-performance

Conversation

@eregon

@eregon eregon commented Sep 12, 2026

Copy link
Copy Markdown

cc @headius

* The stacktrace is not very useful and is very expensive,
  for example for Regexp#to_s on a Regexp like /(?i:a)|(?i:b)/.
* On ruby-bench's railsbench it accounts for about 8% of the request time.
* Rails master has been improved to use #source instead,
  rails/rails#58678,
  but that doesn't affect existing releases.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant