Skip to content

Accept tab as optional whitespace around ranges #72

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
yxshee wants to merge 1 commit into from
Closed

Accept tab as optional whitespace around ranges #72

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 12 additions & 0 deletions src/index.spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -212,6 +212,18 @@ describe("parse(len, str)", () => {
});
});

it("should parse str with tab whitespace", () => {
var range = parse(1000, "bytes=\t40-80,\t81-90\t,-1\t");
expect(range).toEqual({
type: "bytes",
ranges: [
{ start: 40, end: 80 },
{ start: 81, end: 90 },
{ start: 999, end: 999 },
],
});
});

it("should parse non-byte range", () => {
var range = parse(1000, "items=0-5");
expect(range).toEqual({
Expand Down
11 changes: 9 additions & 2 deletions src/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -51,8 +51,8 @@ export function parse(size: number, str: string): Result | -1 | -2 {
// handle ows around numbers
let startStrIndex = index;
let endStrIndex = endIndex;
while (str.charCodeAt(startStrIndex) === 32) startStrIndex++;
while (str.charCodeAt(endStrIndex - 1) === 32) endStrIndex--;
while (isOws(str.charCodeAt(startStrIndex))) startStrIndex++;
while (isOws(str.charCodeAt(endStrIndex - 1))) endStrIndex--;

let start = NaN;
let end = NaN;
Expand Down Expand Up @@ -103,6 +103,13 @@ export function parse(size: number, str: string): Result | -1 | -2 {
return { type, ranges };
}

/**
* Check for optional whitespace (SP / HTAB), RFC 9110 section 5.6.3.
*/
function isOws(code: number): boolean {
return code === 32 || code === 9;
}

/**
* Parse string to integer.
*/
Expand Down