Fix double-escape in handling of ANSI output - #60
Open
jonatanschroeder wants to merge 1 commit into
Open
Conversation
Author
|
@jsvine is there anything I can do to progress with this fix? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #59. When ansi_up is used, it already escapes the output text, so the extra call to escapeHTML is not needed in that context. This change ensures that escapeHTML is only used in potentially ansi output if ansi_up is not being used.
It also extends the escapeHTML to properly handle other escapable characters in HTML, particularly
&.