fix(deps): final CVE sweep — clear all remaining npm audit findings - #111
Merged
Conversation
Closes out the last step of #109: - npm audit fix on the root package: bumps transitive @xmldom/xmldom, fast-xml-parser, fast-xml-builder, nanoid, diff, picomatch, underscore, undici (cheerio), esbuild/vite/vitest (dev), launch-editor. - @mozilla/readability ^0.4.4 -> ^0.6.0 (ReDoS GHSA-3p6v-hrg8-8qj7); its parse() result now types content as nullable, so the null guard in processPage covers it explicitly. - npm audit fix on ui/ (5 high, all transitive). npm audit now reports 0 vulnerabilities in root, ui and mcp. Full test suite passes (729) and both builds are green. Signed-off-by: Denis Jannot <denis.jannot@solo.io>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The last step of #109: after #110,
npm auditstill reported 17 findings in the root package (2 critical, 10 high) and 5 high inui/— all in packages the Snyk PRs never covered.Changes
npm audit fix(semver-compatible transitive bumps): @xmldom/xmldom, fast-xml-parser, fast-xml-builder, nanoid, diff, picomatch, underscore, undici (under cheerio), and dev-only esbuild/vite/vitest/launch-editor.parse()result now typescontentas nullable — the existing null guard inprocessPagecovers it explicitly now.ui/npm audit fix(5 high, all transitive).Result
npm audit: 0 vulnerabilities in root, ui, and mcp.Verification
Full vitest suite: 729 passed / 8 skipped (the website-processing tests exercise readability 0.6). Root
tscbuild anduibuild both green.Part of #109
🤖 Generated with Claude Code