fix(ByoImageValidation): ensure BYO agent validation checks both modelName and byoImage fields - #2451
Open
entee28 wants to merge 4 commits into
Open
fix(ByoImageValidation): ensure BYO agent validation checks both modelName and byoImage fields#2451entee28 wants to merge 4 commits into
entee28 wants to merge 4 commits into
Conversation
…lName and byoImage fields Signed-off-by: Thanh Nguyen <puffle.nnt@gmail.com>
Contributor
There was a problem hiding this comment.
Pull request overview
Fixes a UI validation bug in the Create/Edit Agent page where the BYO “Container image” field could incorrectly show “Container image is required” on blur even when a non-empty value is present (notably in edit mode with a pre-filled image). This aligns the per-field validation payload with how validateAgentFormData distinguishes between Declarative vs BYO agent types.
Changes:
- Update
validateField("model", ...)to populate bothformData.modelNameandformData.byoImage, since the same"model"error slot is reused across Declarative (model) and BYO (container image) flows. - Add a jsdom regression test that covers the edit-mode BYO blur behavior to ensure the “required” error does not appear when the image is already present.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| ui/src/app/agents/new/page.tsx | Ensures per-field validation sets both modelName and byoImage for the shared "model" validation path, preventing false BYO required errors. |
| ui/src/lib/tests/ByoImageValidation.test.tsx | Adds a regression test validating that a pre-filled BYO image does not trigger the “required” error on first blur in edit mode. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
…ent response structure Signed-off-by: Thanh Nguyen <puffle.nnt@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR closes #2450